search

Tessil / ordered-map

C++ hash map and hash set which preserve the order of insertion
MIT License
512 stars 66 forks source link

Add MSVC debugger visualization file #20

Closed cmakshin closed 6 years ago

cmakshin commented 6 years ago

This pull request contains a file which can be used by the Visual Studio debugger for "pretty-printing" tsl::ordered_* containers.

Tessil commented 6 years ago

Hello,

Thank you for your contribution.

I'm currently in holiday without my laptop for the next few weeks, so I can't really test it. I'll check to merge it on my return so that I can check and test it a bit more beforehand as I'm not familiar with the natvis files.

cmakshin commented 6 years ago

Hi Thibaut.

OK, the delay is not a problem.

Have nice holidays! :)

On 08/15/2018 03:54 PM, Thibaut wrote:

Hello,

Thank you for your contribution.

I'm currently in holiday without my laptop for the next few weeks, so I can't really test it. I'll check to merge it on my return so that I can check and test it a bit more beforehand as I'm not familiar with the natvis files.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tessil/ordered-map/pull/20#issuecomment-413188460, or mute the thread https://github.com/notifications/unsubscribe-auth/AZcCWuqIqlfK-wPunOr16QY9AlfnzcqIks5uRBnvgaJpZM4V9Hgz.

Tessil commented 6 years ago

Hello,

I made some minor changes to your branch. If it seems OK to you, I will merge the branch to the master.

cmakshin commented 6 years ago

Hi.

Looks good.

On 09/15/2018 02:36 PM, Thibaut wrote:

Hello,

I made some minor changes to your branch. If it seems OK to you, I will merge the branch to the master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tessil/ordered-map/pull/20#issuecomment-421555293, or mute the thread https://github.com/notifications/unsubscribe-auth/AZcCWiC2_2zQwuBlg8Vw3uFrUrk1hjkIks5ubOYvgaJpZM4V9Hgz.

Tessil commented 6 years ago

I also hesitate to remove the IncludeView="detailed" in bucket_count and max_load_factor. Is there a reason to not leave them in the default view?

cmakshin commented 6 years ago

That's the behavior of the std::unordered_map visualizer shipped with MSVC and I tried to be as close to it as possible.

Tessil commented 6 years ago

Ok, makes sense. I merged the changes.

I'll check to merge the 'natvis' files in the other tsl projects when I have time.

Thank you.