Fix warning by adding "languages" to CMake project declaration

Tessil / sparse-map

C++ implementation of a memory efficient hash map and hash set

MIT License

334 stars 36 forks source link

Fix warning by adding "languages" to CMake project declaration #12

Closed sethrj closed 4 years ago

sethrj commented 4 years ago

With CMake 3.18:

CMake Warning (dev) at /usr/local/Cellar/cmake/3.18.4/share/cmake/Modules/GNUInstallDirs.cmake:225 (message):
  Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
  target architecture is known.  Please enable at least one language before
  including GNUInstallDirs.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

Tessil commented 4 years ago

Looks good, thank you for your contribution.

sethrj commented 4 years ago

Thanks! I'm looking to integrate your sparse map into our group's code base (https://www.ornl.gov/scale) so I may have one or two other contributions soon. It looks like there might be an issue with serialization that I'll try to fix, and I'm also hoping to construct a more standards-friendly workaround to the iterator = const pair<K, V>* rather than iterator = pair<const K*, V>.