search

Test-More / TB2

Test::Builder version 2, the next generation of building testing modules in Perl
Other
1 stars 0 forks source link

Remove Event's as_hash() methods #170

Closed schwernbot closed 10 years ago

schwernbot commented 10 years ago

From: @schwern Date: Tuesday Nov 08, 2011 at 22:07 GMT Orig: https://github.com/Test-More/test-more/issues/185

Test::Builder2::Event now supplies a default as_hash method. Events no longer have to define their own and probably should not. Instead they should override keys_for_as_hash to add any extra non-attributes.

Go through the existing events...

Removing as_hash will pick up more items than the hard coded one did. At minimum it will pick up file and line inherited from Event, but it might pick up more that were forgotten in the override.

schwernbot commented 10 years ago

From: @ssoriche Date: Tuesday Nov 15, 2011 at 01:49 GMT Orig: https://github.com/Test-More/test-more/issues/185#issuecomment-2739798

I'll sign up for this one.

schwernbot commented 10 years ago

From: @schwern Date: Tuesday Nov 15, 2011 at 03:04 GMT Orig: https://github.com/Test-More/test-more/issues/185#issuecomment-2740349

Pull request merged, thanks!