search

Test-More / Test2-Harness

Alternative to Test::Harness
Other
23 stars 26 forks source link

Replace last use of "base" with "parent" #219

Closed JRaspass closed 3 years ago

JRaspass commented 3 years ago

We already depend on parent, but bump it a little to ensure it has support for "-norequire".

exodist commented 3 years ago

Please note that the HashBase.pm and HashBase.t files are generated files, changes to them such as this will get overridden next time HashBase is regenerated. Hashbase is generated using https://metacpan.org/release/Object-HashBase This module is also used to generate the hashbase used in Test-Simple, which cannot be switched to parent because it is such a fundamental dependency (It would cause a dep cycle)

I am fine with the non hashbase portions of this PR, so if you remove the HashBase changes (and leave base in the dep list) I can merge it.

If you REALLY want to remove 'base' from this codebase then you will first need to send a PR to the Object::HashBase repo (which is also mine) that adds a flag to the generator to replace 'base' with 'parent' in the generated results, then run that updated generator in Test2-Harness to make the changes.

Thanks for the PR and your effort on this, I do appreciate it, and I do hope that if the change matters to you that the tiny bit of necessary legwork is not going to stop you. The main issue here is that Test-Simple cannot break or have dep cycles, and this change requires making changes that could effect it. But I am happy to review as many PR's as you are willing to submit, and I will give you pointers as needed to make it happen.

JRaspass commented 3 years ago

Ah gotcha, didn't realise those files came from another dist, I'm paired this commit down to the non Object::HashBase stuff for now.