search

TestArmada / guacamole

A friendly wrapper for the SauceLabs browser and device API
MIT License
11 stars 6 forks source link

Correct Sauce Labs API usage #16

Closed sah closed 7 years ago

sah commented 7 years ago

Corrects a couple of issues with Sauce Labs API usage in the handling of mobile platforms. Mostly, this now trusts long_name to always be a human-readable name which works in the deviceName field.

Note that this changes guacamole IDs.

Maciek416 commented 7 years ago

Thanks so much for this @sah !

Maciek416 commented 7 years ago

Just to reduce confusion in case this PR sits around for a little while: We're going to set aside a bit of time (probably next week, or after next week) to fully absorb the impact of these changes on our end and document a transition for our users.

sah commented 7 years ago

Sounds good. I'm going to see if I can fix these failing tests. If there's some time, I may add a few more tweaks to this PR.

sah commented 7 years ago

Hey, just a reminder in the new year that this branch exists. I just handled some conflicts caused by linting changes in master, so this should be mergeable again.

Maciek416 commented 7 years ago

Thanks for the update!

Maciek416 commented 7 years ago

Conflict resolved against @jherr 's ES6 updates. Going to land this and publish a beta to test in our ecosystem.

Maciek416 commented 7 years ago

Fixing lint nits