TestArmada / guacamole

A friendly wrapper for the SauceLabs browser and device API
MIT License
11 stars 6 forks source link

SauceLabs errs when browserName is not specified for appium emulators #28

Closed chiahrens closed 7 years ago

chiahrens commented 7 years ago

Example: https://saucelabs.com/beta/tests/b2d875e434534c6696a8b85d4f1517a0/metadata#0

I think if browserName is not passed in, SauceLabs sets it to "chrome", so maybe I should just open a ticket with saucelabs. Anyways, just opening this PR since we know that the settings returned by guacamole doesn't work for appium android or ios browsers.

chiahrens commented 7 years ago

Same err for iOS emulator when browserName is not passed in. It sets it to "chrome" - https://saucelabs.com/beta/tests/097de92f388c4fad938e03cee5c2174d/metadata#0

chiahrens commented 7 years ago

Ok, so I think this PR will work.

1) It looks like Nightwatch takes the default value for browserName in nightwatch.json which is often "chrome" or some desktop browser value 2) Guacamole is only used for browser configuration for nightwatch and not for native apps 3) SauceLabs requires either "app" or "browserName" to be specified for Appium android and ios emulators. If neither is specified, it errs. So if a default "browserName" is not set it errs. If it's set incorrectly, it spins up the emulator, but then errors out because it can't find the specified browserName.

chiahrens commented 7 years ago

Ok, so I've been using the Webkit Android and Webkit iPad and iPhone browsers. They all seem to work with the exception of android_x_x_Linux_Android_Emulator. For version 4.4, 5.0, and 5.1, the browserName needs to be 'Browser', and for version 6.0, the browserName needs to be 'Chrome'. I tested this using https://github.com/TestArmada/boilerplate-nightwatch

archlichking commented 7 years ago

💯