search

TestArmada / guacamole

A friendly wrapper for the SauceLabs browser and device API
MIT License
11 stars 6 forks source link

Authenticate requests when env vars present #41

Closed esimons closed 5 years ago

esimons commented 5 years ago

With regards to #40

esimons commented 5 years ago

@Maciek416 @archlichking wondering if we could get a set of eyes on this PR as it's a pressing concern for our group, with builds breaking due to Sauce Labs rate-limiting. Thank you! Sorry for prodding and appreciate your time.

archlichking commented 5 years ago

💯 Thanks for the PR.

archlichking commented 5 years ago

@esimons this repo deprecated. Since magellan@10 we use magellan-saucelabs-executor. Can you also do a PR to it if you're using it?

esimons commented 5 years ago

@archlichking thanks for the merge! I don't think there's anything to change in saucelabs-executor, since it delegates to Guacamole for making calls to the Sauce Labs REST API: https://github.com/TestArmada/magellan-saucelabs-executor/blob/10002ddf81b83fabb3e2483d43e0a64d3c945246/src/profile.js#L5 That being the case, even if this repo is planned to be deprecated, I think we'll need a new release of Guacamole to be published in the meantime.

esimons commented 5 years ago

@archlichking I don't see that a new version of this lib has been published, would it be possible to get this change published soon?