search

TestArmada / guacamole

A friendly wrapper for the SauceLabs browser and device API
MIT License
11 stars 6 forks source link

Add protection from invalid responses #42 #43

Closed michaeljacobdavis closed 5 years ago

michaeljacobdavis commented 5 years ago

Fixes #42 We're assuming data is always an array (because we're using filter and map). We should validate that assumption and if the response does not meet that expectation, throw a helpful error message.

michaeljacobdavis commented 5 years ago

My best guess to what's happening is SuaceLabs is rate limiting this api (429 Too Many Requests) image

In this case, we could retry, or we might want to log the status code. Thoughts?

archlichking commented 5 years ago

the rate limit could be solved by this PR https://github.com/TestArmada/guacamole/pull/41, and it's out in guacamole@3.2.3 referred in https://github.com/TestArmada/guacamole/issues/40.

michaeljacobdavis commented 5 years ago

@archlichking Mind merging and publishing when you have a chance? I don't have rights.