search

TestArmada / magellan-saucelabs-executor

magellan test executor for saucelabs
MIT License
2 stars 2 forks source link

Proxy Support for Outbound Selenium Traffic (control messages) in Nightwatch #12

Closed Maciek416 closed 7 years ago

Maciek416 commented 7 years ago

For nightwatch consumers of magellan-saucelabs-executor, this PR adds support for SAUCE_OUTBOUND_PROXY, which is the same variable used by guacamole@3.2.1

Also:

Note: Support for non-nightwatch frameworks is not covered by this PR because other frameworks only extract desiredCapabilities at this time.

/cc @archlichking

codecov-io commented 7 years ago

Codecov Report

Merging #12 into master will increase coverage by 0.1%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
+ Coverage   87.55%   87.65%   +0.1%     
=========================================
  Files           9        9             
  Lines         474      478      +4     
  Branches       87       89      +2     
=========================================
+ Hits          415      419      +4     
  Misses         59       59
Impacted Files Coverage Δ
lib/settings.js 100% <0%> (ø) :arrow_up:
lib/configuration.js 100% <0%> (ø) :arrow_up:
lib/profile.js 89.13% <0%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 662b12a...37d694a. Read the comment docs.

archlichking commented 7 years ago

👍