search

TestArmada / magellan-saucelabs-executor

magellan test executor for saucelabs
MIT License
2 stars 2 forks source link

Adding support for customized appium desiredCapabilities #19

Closed pranavparikh closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #19 into master will increase coverage by 1.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   85.91%   87.02%   +1.11%     
==========================================
  Files          10       10              
  Lines         582      601      +19     
  Branches      112      113       +1     
==========================================
+ Hits          500      523      +23     
+ Misses         82       78       -4
Impacted Files Coverage Δ
lib/profile.js 94.3% <0%> (+4.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74dc43f...877e627. Read the comment docs.

archlichking commented 6 years ago

By allowing multiple entries in appCapabilitiesConfigFile, the logic of how this executor handles custom (extra) appium capabilities needs to be completely rewritten, which means it also requires changes to current logic of how this executor handles command line --sauce_app_capabilities_config.

Let me restate the new logic.

  1. value from profile.appCapabilitiesConfig and --sauce_app_capabilities_config should be in the same format.
  2. profile.appCapabilitiesConfig and --sauce_app_capabilities_config can co-exist.
  3. if profile.appCapabilitiesConfig and --sauce_app_capabilities_config co-exist, use value from --sauce_app_capabilities_config.
  4. capabilities priority: profile.appium < (profile.appCapabilitiesConfig < --sauce_app_capabilities_config if co-exist) < --sauce_app

Also, please remove all walmart references in the PR.