TestArmada / magellan-saucelabs-executor

magellan test executor for saucelabs
MIT License
2 stars 2 forks source link

Update settings.js #23

Closed esimons closed 6 years ago

esimons commented 6 years ago

fix: the --temp_dir argument wasn't being properly passed to Sauce Connect, so would always default to "./temp". Users that did not have a "./temp" directory at the root of their project (and had configured Magellan to point to an alternate path) would get a mysterious exit code 2 from Sauce Connect when it tried to create a log file at the non-existent path. This fixes that issue.

codecov-io commented 6 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.41%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   85.73%   85.31%   -0.42%     
==========================================
  Files          10       10              
  Lines         610      613       +3     
  Branches      115      116       +1     
==========================================
  Hits          523      523              
- Misses         87       90       +3
Impacted Files Coverage Δ
lib/executor.js 65.25% <0%> (-1.71%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94bc8a9...80502b1. Read the comment docs.

archlichking commented 6 years ago

👍 thanks for the fix @esimons

esimons commented 6 years ago

@archlichking possible to merge despite the ding on coverage metrics? Not familiar with codecov options or why the patch check passed but project did not.

And you're very welcome for the PR, thanks for the great work with this and other projects!

archlichking commented 6 years ago

@esimons i merged it in case you cannot see the merge button.

archlichking commented 6 years ago

@esimons testarmada-magellan-saucelabs-executor@4.11.3 is out with this fix