Maciek416 commented 7 years ago

With extremely high parallelism, we are seeing requests to locks routinely error out.

This new implementation of the executor is intended for a new version of locks that has a websocket API.

/cc @archlichking

codecov-io commented 7 years ago

Codecov Report

Merging #6 into master will decrease coverage by 2.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage    88.3%   86.29%   -2.02%     
==========================================
  Files           9       10       +1     
  Lines         479      562      +83     
  Branches       91      106      +15     
==========================================
+ Hits          423      485      +62     
- Misses         56       77      +21

Impacted Files	Coverage Δ
lib/locks.js	`91.22% <0%> (-8.78%)`	:arrow_down:
lib/locks_socket_api.js	`78.37% <0%> (ø)`
lib/executor.js	`72.64% <0%> (+1.64%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d6efbc...890740b. Read the comment docs.

archlichking commented 7 years ago

👍

TestArmada / magellan-saucelabs-executor

Websocket client for locks #6

Codecov Report