search

TestArmada / magellan

Large Scale Automated Testing for Mocha, Nightwatch, Appium, Nodejs, etc
MIT License
287 stars 44 forks source link

New port allocation rule #219

Closed archlichking closed 7 years ago

archlichking commented 7 years ago

Here is the new Magellan port rule

Standard Magellan port convention:
// let n = settings.BASE_PORT_SPACING - 1;
portOffset       : selenium server
portOffset + 1 : pre-assigned for mocking (available for application to use)
...
portOffset + n : available for application to use

We move the port reserved for selenium server from portOffset + 1 to portOffset. This will allow us allocate less port for scenarios which only one port is required (for selenium server).

This PR also allows executor to have its own port allocation rule. If executor defines its own port rule magellan will use it instead.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2d6570f). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #219   +/-   ##
=========================================
  Coverage          ?   98.86%           
=========================================
  Files             ?       28           
  Lines             ?     1150           
  Branches          ?      193           
=========================================
  Hits              ?     1137           
  Misses            ?       13           
  Partials          ?        0
Impacted Files Coverage Δ
src/test_runner.js 98.34% <100%> (ø)
src/worker_allocator.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d6570f...51c6c3c. Read the comment docs.