search

TestArmada / magellan

Large Scale Automated Testing for Mocha, Nightwatch, Appium, Nodejs, etc
MIT License
287 stars 44 forks source link

Firefox Not running through Magellan #235

Closed joewdriver closed 7 years ago

joewdriver commented 7 years ago

Hello,

I've recently rigged up Magellan and admiral 2 on top of our nightwatch tests. I'm able to run everything fully through chrome, but firefox is not working.

If I bypass magellan and just run directly through nightwatch everything runs without an issue.

When I try and run firefox tests through magellan, I do not get any error output either, tests just don't run. Additionally if I try and submit multiple browsers (chrome,firefox) no tests will run from either.

This is occurring when running from both the seleniumgrid executor and the local executor.

When run in debug mode, it looks like it is not detecting any firefox profile (empty array). Where can I add this back in?

UPDATE:

I've resolved this, the default browser in our Nightwatch.json file is firefox and the corresponding profile information is found there as well. We didn't have a separate profile block for it anywhere else in the file. Because of this, magellan could not find the firefox profile, because it did not know to look in the default block.

archlichking commented 7 years ago

@joewdriver good catch. If you explicitly tell magellan which browser you want to run with by --local_browser, executor simply find that entry in your nightwatch.json and default will be skipped in this case. We're doing this on purpose because nightwatch will merge your browser's desiredCapabilities with default's once it's found, and some of your browser's desiredCapabilities may not be compatible with the browser in default. So what we recommend is to leave desiredCapabilities section empty in default, and have separate entries in test_settings on demand.

joewdriver commented 7 years ago

thanks for the details, keep up the good work!