search

TestArmada / magellan

Large Scale Automated Testing for Mocha, Nightwatch, Appium, Nodejs, etc
MIT License
287 stars 44 forks source link

Use strictly pipes in ChildProcess, also this fixes a bug with the reporters getting unfiltered stdout #290

Closed g00dnatur3 closed 4 years ago

g00dnatur3 commented 4 years ago

Quite simple, use pipes in the ChildProcess.

This fixes a bug in where the reporters can be given the "unfiltered" nightwatch debug log, which is way to large for any reporter to deal with.

Cheers!

below is a screen of the bug this PR fixes

Screen Shot 2020-08-26 at 1 19 58 PM
codecov-commenter commented 4 years ago

Codecov Report

Merging #290 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   96.99%   97.00%   +0.01%     
==========================================
  Files          31       31              
  Lines         997     1001       +4     
==========================================
+ Hits          967      971       +4     
  Misses         30       30
Impacted Files Coverage Δ
src/util/childProcess.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ff9431...aada7c7. Read the comment docs.