search

TestArmada / magellan

Large Scale Automated Testing for Mocha, Nightwatch, Appium, Nodejs, etc
MIT License
287 stars 76 forks source link

fixed bugs with the nightwatch logs not showing up correctly #294

Closed g00dnatur3 closed 3 years ago

g00dnatur3 commented 3 years ago

The nightwatch logs were not showing correctly.

this PR fixes them to show correctly,

Code has been verified using a real world project with many test cases.

please see screenshot for verification of the code working correctly

Screen Shot 2020-09-11 at 1 28 43 PM
codecov-commenter commented 3 years ago

Codecov Report

Merging #294 into master will increase coverage by 0.19%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   96.05%   96.24%   +0.19%     
==========================================
  Files          31       31              
  Lines        1013     1011       -2     
==========================================
  Hits          973      973              
+ Misses         40       38       -2
Impacted Files Coverage Δ
src/util/childProcess.js 87.30% <50.00%> (+2.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 597c9e6...cf7ae89. Read the comment docs.