TestArmada / nightwatch-extra

MIT License
30 stars 25 forks source link

Added support for .js configuration extension #109

Closed ViljarVoidula closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #109 into master will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   98.93%   99.05%   +0.11%     
==========================================
  Files          21       21              
  Lines         943      951       +8     
  Branches      159      160       +1     
==========================================
+ Hits          933      942       +9     
+ Misses         10        9       -1
Impacted Files Coverage Δ
lib/settings.js 100% <0%> (+2.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41bb357...f1d27d6. Read the comment docs.

pschroeder89 commented 6 years ago

Can we get this merged, please?

archlichking commented 6 years ago

Great stuff, thanks @pschroeder89. We'll publish a beta version for it, test it and if everything is good we'll bump nightwatch-extra@5.1.0 for it together with https://github.com/TestArmada/nightwatch-extra/pull/113.

archlichking commented 6 years ago

testarmada-nightwatch-extra@5.1.0-beta1 is out