search

TestCaTissue / catissueRepo

For catissue data migration
0 stars 0 forks source link

Advanced Query starts with Participant Query rule #363

Closed TestCaTissue closed 10 years ago

TestCaTissue commented 10 years ago

CATDEVNIH-362: Is there any reason behind starting the Advanced query with participant query before adding the rules? If I do not wish to include participant information, why should I specify predicates for it?

TestCaTissue commented 10 years ago

Original reporter: rdhaval@regenstrief.org

TestCaTissue commented 10 years ago

watsonm@pathology.wustl.edu: The purpose of the advaced query is advanced. In order to create a hierarchical query based on our object model, you always need to start at the top (participant) and work down the relational tree. If you have no constraints on participant you can select "any." If this is too advanced or cumbersome, then you can probably use the simple query and start at the specimen level. The simple query is simpler but less advanced :)

TestCaTissue commented 10 years ago

aarti_sharma@persistent.co.in_no_email: We will discuss this more here but its not a feature of current release so moving it to version 1.1.

TestCaTissue commented 10 years ago

rdhaval@regenstrief.org: In order for the advanced query to be actually advanced, it has to have advanced features. :) The advanced query should not be constrained on the basis of participant or for that matter any object. If I have no constraints on participant I shoud not be asked to select "any". The query should be able to traverse the path according to the object model starting from any object.

TestCaTissue commented 10 years ago

sadiga: Attachment page2_withoutnames.jpg has been added with description: Image with links to objects on the LHS

TestCaTissue commented 10 years ago

prafull_kadam@persistent.co.in_no_email: Added a default page for selecting node to start for AdvanceQuery interface.

Files added/changed: AdvanceQueryInterfaceDefaultPageAction.java (1.1) AdvanceQueryInterfaceDefaultPage.jsp (1.1) ApplicationResources.properties(1.310) Search.jsp(1.13) struts-config.xml(1.207) tiles-defs.xml(1.81)

TestCaTissue commented 10 years ago

sadiga: Rasing the priority.

TestCaTissue commented 10 years ago

sadiga: Created an attachment (id=626) Image with links to objects on the LHS

Aarti, Poornima,

This should be fixed for v1.1. The attached image was one of the initial images the UE team had created.

use FUNES-1: If someone wants to query for only specimen, user clicks on the specimen link and the system takes the user directly to that specimen page and the query tree at the bottm displays ANY for all the all the other objects above specimen.

use case #2:

  1. user enters predicates for participant
  2. user clicks on specimen
  3. system takes the user to specimen page and fills in ANY for all the objects in between.

The only change in the UI is: put the individual object icon along with the links in the LHS

~Sri

TestCaTissue commented 10 years ago

prafull_kadam@persistent.co.in_no_email: Also Modified Following files: ConditionMapParser.java (1.12) AdvanceSearchAction.java(1.23) AdvanceQueryView.jsp(1.39)

Added logic to Add "Any" Query Condition nodes wherever required. For ex. When user has added Participant rule & user tries to add Query Rule on Specimen by selecting Participant rule, it will create "Any" condition node for Collection Protocol & Specimen Collection Group irrespective of whether the Rules for Collection Protocol & collection Group is already added or not.

TestCaTissue commented 10 years ago

sadiga: Moving to advanced query....

TestCaTissue commented 10 years ago

prasanna_kashikar@persistent.co.in_no_email: Bug having Status as "Verified" and Resolution as "FIXED" or InValid" is Closed.

TestCaTissue commented 10 years ago

ashit_khobaragade@persistent.co.in_no_email: "Tested and Found fixed on build of sep29.Please close if satisfied with the fix"