TestCentric / net20-pluggable-agent

A pluggable agent allowing tests to run under .NET 2.0 in the TestCentric GUI
MIT License
0 stars 0 forks source link

Revert to use of version 3 of the NUnit engine API #21

Closed CharliePoole closed 1 year ago

CharliePoole commented 1 year ago

The extension was developed using the NUnit Engine development branch but version 4 is not likely to come out soon so we should use a production version. This may be as simple as just changing the package references or it may introduce further problems to resolve.

The most likely problem has to do with a change in the semantics of the TestPackage constructor between the NUnit 3 and 4 APIs.

YashUoM commented 1 year ago

Update: Starting with this one

YashUoM commented 1 year ago

Hi Charlie,

Can you elaborate this little more?

CharliePoole commented 1 year ago

@YashUoM

Sure... first step, of course, will be to find and change all references to nunit.engine.api 4.0.0-dev00102 to 3.16.2. This will be primarily in the project files but also check build.cake just in case.

While you are at it, you should probably also update all references to the testcentric engine to the latest dev version on MyGet.org, which is currently 2.0.0-dev00033.

With the TestPackage constructor, you will need to change any new TestPackage(file) specifying a single file argument to new TestPackage(new [] { file }). Most of these will be in the tests.

CharliePoole commented 1 year ago

@YashUoM Yet another small "while you are at it" task in this extension...

The tools directory contains multiple assemblies but only one of them implements the extension. But the engine has to examine all of them, which is inefficient. If the tools directory contained a *.addins file pointing to the correct assembly, then only that one would be examined.

The addins file can be named anything, e.g. net20-pluggable-agent.addins and should contain one line with net20-agent-launcher.dll. When the engine examines a directory containing a *.addins file or files, it only looks at the content of those files and doesn't look at other assemblies in the same directory.

Please treat this as an "extra" and skip it if you need to.

CharliePoole commented 1 year ago

FYI I just released testcentric engine 2.0.0-alpha7. Use that for any testcentric engine references. No release of the Gui itself yet, but coming soon.

CharliePoole commented 1 year ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on: