search

TestCentric / testcentric-engine

Test engine that loads and runs tests for TestCentric
MIT License
0 stars 3 forks source link

TestAssemblyResolver doesn't handle dotnet preview releases correctly #85

Closed CharliePoole closed 1 year ago

CharliePoole commented 1 year ago

This problem was discovered after installing .NET 8.0 preview 1. The code in TestAssemblyResolver.cs contains two particular issues:

  1. The directory returned by FindBestVersionDirectory assumes that the directory name is something like 8.0.0 when in fact it may contain a preview label like 8.0.0-preview.xxxx.

  2. The code compares two version numbers for equality without allowing for differences in the number of components. This causes an error because new Version("8.0.0.0") compares as less than new Version("8.0.0").

CharliePoole commented 1 year ago

:tada: This issue has been resolved in version 2.0.0-alpha8 :tada:

The release is available on: