TestCentric / testcentric-gui

TestCentric GUI Runner for NUnit
Other
67 stars 30 forks source link

`ArgumentNullException` parameter `tests` at `TestCentric.Gui.Model.TestModel.RunTests(TestSelection tests)` #1045

Closed maettu-this closed 4 months ago

maettu-this commented 4 months ago

This issue is extracted from https://github.com/TestCentric/testcentric-gui/issues/1043 as it is an additional finding.

Describe the bug See "TestCentric 2.0.0-beta4 with SetUpFixture workaround" resulting in: 320388447-c914d5ee-8e1a-4ca3-8feb-9c77218be1d4

To Reproduce

  1. Build TextOutputIssue.zip
  2. Open the assembly in TC 2.0.0-beta4

Expected behavior No exception. Even better, an error message describing the why no tests could be loaded.

Screenshots See above.

Environment (please complete the following information):

CharliePoole commented 4 months ago

Same as #1044. I'm not seeing the issue.... there is no crash. Your trace output does appear, but after the specific Progress outputs. Looking more closely, this seems to be the correct code for #1045.

maettu-this commented 4 months ago

This one is more tricky, I cannot reproduce each time either. I have tried to find a way to make it reproduce each time, e.g. just the first time after having installed TC, or after having switched from TC 1.6.4 to 2.0.0-beta4, but haven't found a reliable way so far.

trace output does appear, but after the specific Progress outputs

This is expected, the above linked TextOutputIssue.zip is the initial version using the ConsoleTraceListener.

You can also try with TextOutputIssue.with.ProgressTraceListener.zip. That outputs text in correct sequence, but appart from that, it also sometimes lets TC crash and running the same test multiple times also results in multiplicated output.

CharliePoole commented 4 months ago

Something is off here. You describe this as happening when the tests are loaded but the exception you show indicates it was thrown when running the tests. In any case, I cannot reproduce this so I'll close it. We can re-open if you find a reliable repro.