search

TestRoots / watchdog

IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested
http://www.testroots.org
Other
18 stars 10 forks source link

Adds multi IDE support for WatchDog. #178

Closed Inventitech closed 9 years ago

Inventitech commented 9 years ago

Refs #177

Inventitech commented 9 years ago

@levaja , what do you think? One of things I am a bit uncomfortable with is that we have to rely on the Eclipse activator to paste in the correct WD host. In that sense, even the modified unit tests do not really test what we want (they merely assert the correct JSon creation).

The only way we could go about that is by having plugin tests, but they are not easy to setup, as that would require a working Eclipse plugin environment with WatchDog preconfigured. So, although not ideal, I'd suggest to defer testing this specific feature for now.

Inventitech commented 9 years ago

The beauty of this implementation on the other hand is that we can refactor WatchDogGlobals and WDT as is into WDcore.

levaja commented 9 years ago

I've checked, this looks good to me.

Maybe we don't have to rely on Eclipse activator, maybe we can set up this on our side, in deployed plugin?

We will still have 2 separate plugins and I think we can add this as a part of "package" that we ship. Whoever downloads Eclipse version will get IDE.ECLIPSE and whoever downloads IntelliJ version will get IDE.INTELLIJ.