search

TestRoots / watchdog

IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested
http://www.testroots.org
Other
18 stars 10 forks source link

Adds support for tracking a debug interval #232

Closed nspruit closed 8 years ago

nspruit commented 8 years ago

This PR adds support for tracking and visualizing debug intervals. For this, the following steps have been performed:

  1. Add DebugInterval type to the core project
  2. Add a start and end debug event and adapt the EventManager to create/close DebugIntervals based on these events
  3. Generate these debug events by adding a new listener for events fired by the debugger in both IJ and Eclipse
  4. ~~Add a Debugging activity to the first two plots in the WatchDogView of both IDEs based on the generated DebugIntervals~~

The results of these steps can be seen in the following two screenshots showing the WatchDogView in both IDEs:

Inventitech commented 8 years ago

Cool. Just one question, and that might be because I don't know when a case DebugEvent.CREATE or TERMINATE event is thrown: Why do you represent debugging as opposed to reading and writing? Couldn't you be debugging and writing or reading?

Inventitech commented 8 years ago

I was meaning to release WD-1.7 with the new bug fixes https://github.com/TestRoots/watchdog/tree/wd-v1.7; would you consider the functionality in this PR to be stable enough to make it into the new release, or would you rather like to wait and release it with the rest of the debug functionality?

nspruit commented 8 years ago

From the documentation:

So you're right, you can still read or write while debugging. Therefore, the development activities in the new WDView are no longer disjoint. However, the currently shown activities in the view can all overlap with a debug interval. So: do you have an idea where to show this new activity in the view?

Based on this finding I would postpone the integration of this PR to the next release. This will also be easier for analysing the data later on, as I can then filter out all WD versions except the one containing all functionality for tracking debug activities (v2.0?).

Inventitech commented 8 years ago

OK, sounds good to me.

Inventitech commented 8 years ago

What about displaying it in a new chart row on debugging? :)

nspruit commented 8 years ago

That is an appropriate solution, I'll see what might be interesting to visualize in this row in Phase 4.

For now, I'll remove the debugging statistics from the WDView.

nspruit commented 8 years ago

The changes to the WDView have now been reverted, so this PR now only makes sure that debug intervals are tracked in Eclipse and IntelliJ.

Inventitech commented 8 years ago

Hi Niels,

Can you file this PR against the new branch wd-2.0? Then I can directly accept it .

Moritz

nspruit commented 8 years ago

Sure, see #235. I'll close this PR then