search

TestRoots / watchdog

IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested
http://www.testroots.org
Other
18 stars 10 forks source link

Load correct localized messages.properties for CheckStyle #290

Open TimvdLippe opened 6 years ago

TimvdLippe commented 6 years ago

Reading through https://github.com/checkstyle/checkstyle/blob/489ce031e818f955a95c10d9f10668cb1b7b4b54/src/main/java/com/puppycrawl/tools/checkstyle/api/LocalizedMessage.java#L367-L377 showed that we actually need to pass in the Locale for the given bundle, to load the correct message. The Locale we should load is the Locale.getDefault().

Inventitech commented 6 years ago

How is this affecting our current plans?

TimvdLippe commented 6 years ago

This is not blocking right now, but an enhancement for later. It mostly requires investigation, as I suspect we already deal with this case.