search

TestRoots / watchdog

IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested
http://www.testroots.org
Other
18 stars 10 forks source link

Enable checkstyle #292

Closed TimvdLippe closed 6 years ago

TimvdLippe commented 6 years ago

Enable CheckStyle to make sure we maintain a uniform codebase. The configuration also comes with http://editorconfig.org/ which makes sure developers do not need to worry about formatting. The editor will do that automatically for you.

Also make all test method names uniform to snake_case, as that is more readable when analyzing CI logs.

Lastly, fix an issue with the persister tests, which had inter-dependency. This was first solved with a custom runner, but this is a brittle approach as single tests can then no longer be executed. Instead, 1 testcase should be used and for readability the logic should be split into multiple private methods.

Fixes #283

TimvdLippe commented 6 years ago

Reviewing is a lot easier on https://github.com/TestRoots/watchdog/pull/292/files?w=1

Inventitech commented 6 years ago

Hi Tim,

Thanks. See my comment above.

Moritz

TimvdLippe commented 6 years ago

@Inventitech Fixed the typo and normalized the test assertions from private methods to a single method instead.

Inventitech commented 6 years ago

Do we still need private static IntervalBase interval; as a member variable in IntervalPersisterSingleIntervalTest.java?

TimvdLippe commented 6 years ago

We do not :smile: