TestRoots / watchdog

IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested
http://www.testroots.org
Other
19 stars 10 forks source link

When WatchDog server returns 500, the user does not see this #314

Closed Inventitech closed 6 years ago

Inventitech commented 6 years ago

Trying to register a new user, when this is not successful, the UI does not change at all.

TimvdLippe commented 6 years ago

Is this Eclipse or IntelliJ or both?

TimvdLippe commented 6 years ago

Oh it is actually easy. We have to update the following snippet to catch Exception instead:

try {
            userId = new JsonTransferer().registerNewUser(user);
        } catch (ServerCommunicationException exception) {
            this.createFailureMessage(USER_CREATION_MESSAGE_FAILURE, exception);

            return false;
        }
TimvdLippe commented 6 years ago

Okay, it is not that easy sadly. It seems we are already catching this exception appropriately down in the JsonTransferer