Verbose test smell threshold set to 123?

TestSmells / TestSmellDetector

A tool to detect test smells in Java projects that utilize JUnit as the testing framework

https://testsmells.github.io/

GNU General Public License v3.0

73 stars 39 forks source link

Verbose test smell threshold set to 123? #3

Open ishepard opened 4 years ago

ishepard commented 4 years ago

Hi! Thanks for the tool! I was looking at the threshold of Verbose Test, and it's currently set to 123 statements. I think this is an error, it seems waaay to high, and also it's kind of a magic number (first 3 numbers of the keyboard). Is it a leftover? What's the correct threshold?

https://github.com/TestSmells/TestSmellDetector/blob/08be07d40db84d6c6ef3a29e00d827a4d3c98011/src/main/java/testsmell/smell/VerboseTest.java#L61

mkaouer commented 4 years ago

Hi Davide, Thank you for taking the time to try the tool. Indeed any threshold can be definitely optimized either by making it user-defined or by using intelligent (learning from instances labeled by human annotators). @shehan How did we initialize this threhold?