search

TestSmells / TestSmellDetector

A tool to detect test smells in Java projects that utilize JUnit as the testing framework
https://testsmells.github.io/
GNU General Public License v3.0
73 stars 41 forks source link

Multi-OS compatibility #5

Closed giograno closed 4 years ago

giograno commented 4 years ago

I was trying out the tool on MacOS and I found out that it was crashing due to the some splits on file paths where the file separator was hard-coded for Windows. I replaced those occurrences with File.separator and it now words for Unix systems. I also wrote the TestFileTest suite to check the behavior on both Unix and Windows systems. I did not try to execute the Windows tests tough.

I have a question about the getTagName() method of the TestFile class. What is that supposed to do? Inspecting the Main it seems it should get the version of the project, but its implementation seems obscure to me.

I also modified the pom file to package everything from Maven. Thank you very much

giograno commented 4 years ago

@victorgveloso you are right, I included by mistake df53159 that only computed assertion roulette and eager test (that I needed for other purposes). Now it calculates everything