Closed AlexArchive closed 9 years ago
AlexArchive
commented
9 years ago On second thought:
This will probably be a breaking change as ExpressionStringBuilder surrounds lambda arguments in parentheses (e.g. "(user) =>") as where our current implementation does not (e.g. "user =>").
We already have some breaking changes queued up (i.e. current version is 3.0 but the last published package is 2.2.0) so I don't think it's a big deal.
Let me know what you think. Cheers.
robdmoore
commented
9 years ago Fine by me
On 17 Mar 2015, at 6:46 pm, ByteBlast notifications@github.com wrote:
On second thought:
This will probably be a breaking change as ExpressionStringBuilder surrounds lambda arguments in parentheses (e.g. "(user) =>") as where our current implementation does not (e.g. "user =>").
We already have some breaking changes queued up (i.e. current version is 3.0 but the last published package is 2.2.0) so I don't think it's a big deal.
— Reply to this email directly or view it on GitHub.
Remember how we were working on improved messages?
In the end we decided to implement a simplistic class (ExpressionInspector) - we thought to improve it upon demand. There is now a package for this (ExpressionToString) who handles advanced cases. Should we bring it in?
I think we will call it from ExpressionInspector. I wrote a bunch of tests to prevent against breaking changes.