TestStack / TestStack.Seleno

Seleno helps you write automated UI tests in the right way by implementing Page Objects and Page Components and by reading from and writing to web pages using strongly typed view models.
http://teststack.github.com/TestStack.Seleno/
MIT License
180 stars 60 forks source link

Fixed issue introduced with DomCapture #178

Closed dennisroche closed 9 years ago

dennisroche commented 9 years ago

In PR https://github.com/TestStack/TestStack.Seleno/pull/168, a new Castle Dynamic Proxy Interceptor was introduced to output the DOM on exception. This unfortunately broke the existing feature that captures a screenshot.This was noted by @robdmoore after https://github.com/TestStack/TestStack.Seleno/pull/168 was merged and I discovered last week when working on another contribution.

I discussed the problem with @robdmoore before starting work on this issue.

In this PR:

robdmoore commented 9 years ago

Hmm, CI auto-builds don't seem to be running. @JakeGinnivan is ci still up :P

dennisroche commented 9 years ago

@JakeGinnivan if you are fixing the CI servers, it would be great to get the Team City build status badge displayed on the GitHub page.

JakeGinnivan commented 9 years ago

CI is still up and they are building PR's.

Just looks like GitHub reporting isn't setup

image

aaronpowell commented 9 years ago

Autofac Interceptors!

¯\_(ツ)_/¯

dennisroche commented 9 years ago

@aaronpowell it took me a week on/off to understand how Dynamic Proxy worked. :)

dennisroche commented 9 years ago

I think it would be best to merge https://github.com/TestStack/TestStack.Seleno/pull/179 first as @mwhelan has also modified ScreenshotTests.cs. I don't mind rebasing.

robdmoore commented 9 years ago

FYI the big merge has been done so this can be fixed to be merged now.

I'm happy for @mwhelan or @MehdiK to merge it if they are happy with it. The changes look good. Thanks!