search

TestStack / TestStack.Seleno

Seleno helps you write automated UI tests in the right way by implementing Page Objects and Page Components and by reading from and writing to web pages using strongly typed view models.
http://teststack.github.com/TestStack.Seleno/
MIT License
180 stars 60 forks source link

Fix broken documentation link #222

Closed kalenwatermeyer closed 8 years ago

kalenwatermeyer commented 8 years ago

Readme.md The link to Seleno documentation is broken.

I've updated the URL to point to: http://seleno.teststack.net/docs/introduction-to-seleno

robdmoore commented 8 years ago

Can you please make it http://seleno.teststack.net instead?

kalenwatermeyer commented 8 years ago

Hi @robdmoore - I've updated the documentation url as requested.

(I'm a noob with the online GitHub pull request workflow - sorry if I've messed it up!)

robdmoore commented 8 years ago

Hi @kalenwatermeyer - thanks for the PR :)

It looks like you created pull requests to your own master branch and then created a pull request from your master branch to Seleno - this meant that rather than one commit there was 4 commits. Because of that, in this case I've made the change myself.

In the future you can create a pull request from a non-master branch directly to Seleno (or any other repository) - that will come through a lot cleaner :) There is some more information here FYI: https://help.github.com/articles/using-pull-requests/

Thanks again :)

kalenwatermeyer commented 8 years ago

Thanks for the tip Rob - I'll get my pull requests right next time!

Cheers Kalen

On 8 November 2015 at 05:14, Rob Moore notifications@github.com wrote:

Hi @kalenwatermeyer https://github.com/kalenwatermeyer - thanks for the PR :)

It looks like you created pull requests to your own master branch and then created a pull request from your master branch to Seleno - this meant that rather than one commit there was 4 commits. Because of that, in this case I've made the change myself.

In the future you can create a pull request from a non-master branch directly to Seleno (or any other repository) - that will come through a lot cleaner :) There is some more information here FYI: https://help.github.com/articles/using-pull-requests/

Thanks again :)

— Reply to this email directly or view it on GitHub https://github.com/TestStack/TestStack.Seleno/pull/222#issuecomment-154773126 .