search

TestableIO / System.IO.Abstractions

Just like System.Web.Abstractions, but for System.IO. Yay for testable IO access!
http://www.nuget.org/packages/System.IO.Abstractions
MIT License
1.51k stars 254 forks source link

chore(deps): update dependency nunit to v4 #1058

Closed renovate[bot] closed 9 months ago

renovate[bot] commented 10 months ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
NUnit (source) 3.14.0 -> 4.0.1 age adoption passing confidence

Release Notes

nunit/nunit (NUnit) ### [`v4.0.1`](https://togithub.com/nunit/nunit/releases/tag/v4.0.1): NUnit 4.0.1 Patch release to fix windows targets See [release notes](https://docs.nunit.org/articles/nunit/release-notes/framework.html#nunit-401---december-2-2023) and See [migration guide](https://docs.nunit.org/articles/nunit/release-notes/Nunit4.0-MigrationGuide.html) ### [`v4.0.0`](https://togithub.com/nunit/nunit/blob/HEAD/CHANGES.md#NUnit-400---November-26-2023) All changes, see [release notes](https://docs.nunit.org/articles/nunit/release-notes/framework.html#nunit-400)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Mend Renovate. View repository job log here.

vbreuss commented 10 months ago

Please note, that NUnit v4 does not support net461, net5.0 and netcoreapp3.1:

The minimum target framework supported is now dotnet framework 4.6.2, and .net 6.0.

fgreinacher commented 10 months ago

Please note, that NUnit v4 does not support net461, net5.0 and netcoreapp3.1:

The minimum target framework supported is now dotnet framework 4.6.2, and .net 6.0.

Thanks for pointing that out @vbreuss.

Maybe this would be a good opportunity to remove all unsupported .NET versions from our test projects, WDYT?

vbreuss commented 10 months ago

Maybe this would be a good opportunity to remove all unsupported .NET versions from our test projects, WDYT?

Currently we support the following frameworks:

<TargetFrameworks>net8.0;net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0;net461</TargetFrameworks>

I think it is no longer necessary to support, e.g. net5.0 or netcoreapp3.1 in the test projects (and also in the actual projects) as consumers would fall-back to netstandard2.0.

It is more difficult with net461. According to this page:

While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher.

So if we remove net461 from the test project, I think we should also update the .NET Framework version in the other projects, which would be a breaking change...

fgreinacher commented 10 months ago

I think we can upgrade to .NET 4.6.2. that one is still supported for a few years, see https://learn.microsoft.com/de-de/lifecycle/products/microsoft-net-framework.

vbreuss commented 10 months ago

I think we can upgrade to .NET 4.6.2. that one is still supported for a few years, see https://learn.microsoft.com/de-de/lifecycle/products/microsoft-net-framework.

I created #1060 to update the supported frameworks.

vbreuss commented 10 months ago

Before we can update to NUnit v4 we have to either wait for a new version of Snapshooter (see https://github.com/SwissLife-OSS/snapshooter/pull/188) or find a new way for ApiParityTests.

fgreinacher commented 10 months ago

Before we can update to NUnit v4 we have to either wait for a new version of Snapshooter (see SwissLife-OSS/snapshooter#188) or find a new way for ApiParityTests.

Let's wait a bit, the PR seems to make good progress.

fgreinacher commented 9 months ago

I cherry-picked https://github.com/TestableIO/System.IO.Abstractions/pull/1058/commits/bc4723f23f15d6f020eb672285e4da0b906dd898 to get the new Snapshooter version.

renovate[bot] commented 9 months ago

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

âš  Warning: custom changes will be lost.

github-actions[bot] commented 8 months ago

This is addressed in release v20.0.15.