Match function prototypes from TwoWire

Testato / SoftwareWire

Creates a software I2C/TWI bus on every pins

GNU General Public License v3.0

148 stars 33 forks source link

Match function prototypes from TwoWire #29

Closed ahnolds closed 3 years ago

ahnolds commented 4 years ago

This allows the overloads to be called correctly through a TwoWire pointer. In particular, endTransmission and RequestFrom didn't match the TwoWire prototypes, which causes issues when attempting to call through a pointer to a TwoWire object.

ahnolds commented 4 years ago

Won't help right now since currently TwoWire methods aren't virtual. However, I've put in a PR there to make them virtual for this: https://github.com/arduino/ArduinoCore-avr/pull/331

In the mean time, it shouldn't hurt

Testato commented 3 years ago

closed due to https://github.com/Testato/SoftwareWire/pull/32