search

Testausserveri / testausserveri.fi

🧪 Homepage for Testausserveri - community of young Finnish hackers
https://testausserveri.fi
MIT License
12 stars 20 forks source link

fix(#97): disable scroll when navbar is in fullscreen #102

Closed antoKeinanen closed 1 year ago

antoKeinanen commented 1 year ago

To implement the fix, I have made the following:

  1. Added "react-remove-scroll" as a dependency on the project.
  2. Move the navbar's open state hook 1 layer up (Header.tsx -> _app.tsx).
  3. Wrap Component in RemoveScroll controlled by the navbar's open state hook.

fixes #97

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testausserveri-fi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 1:17pm
Eldemarkki commented 1 year ago

Also, add a Fixes #97 text to the PR description to automatically close the issue.

Vantaa3 commented 1 year ago

lgtm