Various small improvements

Testausserveri / testausserveri.fi

🧪 Homepage for Testausserveri - community of young Finnish hackers

https://testausserveri.fi

MIT License

12 stars 19 forks source link

Various small improvements #92

Closed Eldemarkki closed 1 year ago

Eldemarkki commented 1 year ago

Optimize images to make the site load faster
Upgrade to Next.js 13 and React 18
- This required swapping and removing some dependencies (including @testausserveri/react-testausid)
Improve SEO and HTML semantics, this significantly improved Google Lighthouse scores on most pages
Add ESLint
Switch from Babel to SWC, which is currently the recommended compiler by Next.js
Removed some unused dependencies

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
testausserveri-fi	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 21, 2023 at 11:50AM (UTC)

Esinko commented 1 year ago

React-testausid should not be removed, but for now it'll have to do. Is it possible that you could do some housekeeping there too @Eldemarkki? The documentation should be easy enough to interpret. There's quite a bit of housekeeping to do there though.

Esinko commented 1 year ago

Also there are some conflicts in this PR atm.

Eldemarkki commented 1 year ago

@Esinko Fixed the conflicts. And yes I agree, react-testausid should not be removed, but it was slowing down development (due to not supporting React 18) and I decided it was appropriate to remove it because it wasn't even used in production.

I've tried to fix https://github.com/Testausserveri/react-testausid/issues/2 a few times, but I've had many problems with setting up the development environment. I can try again when I have more time (likely within a 1-2 weeks).

Esinko commented 1 year ago

Sorry abt the close (misclick) Anyhow, LGTM! Merge? @ahnl