search

TestingResearchIllinois / idoft

32 stars 227 forks source link

Opened PRs for 14 fixed tests #1213

Closed Doom-Prophet closed 9 months ago

Doom-Prophet commented 9 months ago

VM: 093

Logs: home/zicheng5/new-tests

All logs are in corresponding repo-named folder with extension ".nondex_log"

The one newly found and fixed test: "testInfraNamedWindowViews" is recorded

darko-marinov commented 9 months ago

Please squash the commits. If you have more to add, consider whether to open a new PR or keep updating this one. Smaller PRs are easier to review and accept.

Doom-Prophet commented 9 months ago

Please squash the commits. If you have more to add, consider whether to open a new PR or keep updating this one. Smaller PRs are easier to review and accept.

I will be adding some more these two days, do I need to wait till all of them added and then squash them all, or just squash these five first?

darko-marinov commented 9 months ago

Squash these now. You can add new ones as new PRs not by updating this PR.

Doom-Prophet commented 9 months ago

Just squashed.

darko-marinov commented 9 months ago

I can accept the changes on esper, but for junit4, please put Opened unless the developers add some fix, in which case add a link to their commit in the last column Notes.

Doom-Prophet commented 9 months ago

Commit made, do I need to squash this one as well?

darko-marinov commented 9 months ago

Please keep in this PR only Opened (and squash all commits into one). The other case(s) -- whether MovedOrRenamed,DeveloperFixed`, or anything else -- should be in another PR.

Doom-Prophet commented 9 months ago

I've made this PR only Openedand squashed them together as you wish, shortly afterwards I will set up a new branch and open another PR for MovedOrRenamedand DeveloperFixed

darko-marinov commented 9 months ago

Accepting this so you get some "points" for now. You may want to clean https://github.com/espertechinc/esper/pull/279/files as it's likely to be rejected.

Doom-Prophet commented 9 months ago

Accepting this so you get some "points" for now. You may want to clean https://github.com/espertechinc/esper/pull/279/files as it's likely to be rejected.

Do you mean the "clean" by squashing all commits there into one as well? Or are you expecting more beyond that?

darko-marinov commented 9 months ago

Start by squashing but you should really (1) delete old code rather than commenting it out and (2) extract common expressions as I'm not even sure if all the fixes work with some expressions repeated (where NonDex could shuffle the same expressions differently in two evaluations).