search

TestingResearchIllinois / idoft

34 stars 248 forks source link

Added Opened status for Sentinel PR #1355

Closed hermya closed 2 weeks ago

hermya commented 2 weeks ago

Adding Opened status for time zone dependent test, with PR at: https://github.com/alibaba/Sentinel/pull/3459

darko-marinov commented 2 weeks ago

Please change the checker with the new category

darko-marinov commented 2 weeks ago

Please rebase your changes on the latest main now that I accepted #1356

darko-marinov commented 2 weeks ago

Not sure if you're working on The file is not properly ordered.

darko-marinov commented 2 weeks ago

Can you squash 8 commits into 1? You're just adding one new line, so no need for 8 commits to ad one line.

darko-marinov commented 2 weeks ago

This PR currently has some unnecessary changes in pr-data.csv (and two commits instead of one).

hermya commented 2 weeks ago

Apologies for taking so many tries to reduce the changes to one commit