Remove hardcoded 30s wait timeout for navigation

TestingWithFrank / Frank

Automated acceptance tests for native iOS apps

http://testingwithfrank.github.io/

Apache License 2.0

215 stars 57 forks source link

Remove hardcoded 30s wait timeout for navigation #24

Closed joemasilotti closed 10 years ago

joemasilotti commented 10 years ago

Steps

I wait to see a navigation bar titled "..."
I wait to not see a navigation bar titled "..."

MichaelBuckley commented 10 years ago

This will make these steps use the default 240-second timeout. Is that the intention of this pull request?

joemasilotti commented 10 years ago

The intention of the pull request was to not override any user settings for timeouts. All methods should be using the set WAIT_TIMEOUT.

Also, having a default 240 second timeout is way longer than it should be to do any viable testing with wait_until methods. I vote that the default timeout is dropped to something more reasonable, say 10 seconds.

MichaelBuckley commented 10 years ago

Oh, right. I forgot about WAIT_TIMEOUT. Sorry. I'll merge this in.