Tetra-cube / Tetra-cube.github.io

Reposity for all the various tools I make.
176 stars 65 forks source link

Skeleton Preset Issue #5

Closed RecursiveStar closed 4 years ago

RecursiveStar commented 5 years ago

Your skeleton preset is missing the condition immunity for exhaustion and the damage immunity for poison.

Great tool you have here, though :)

EDIT: Ghoul statblock is missing the damage immunity for poison as well as its immunities to the charmed and exhaustion conditions as well.

daft-develop commented 4 years ago

I looked at the code and it appears the stats are pulled from api.open5e.com. I've confirmed on open5e's end the same values are missing, so I've generated a pull request on that project to add the missing values for both creatures. If the PR gets accepted, it should automatically get picked up on Tetra-cube on a page reload.

API call for Skeleton: https://api.open5e.com/monsters/?name=Skeleton API call for Ghoul: https://api.open5e.com/monsters/?name=Ghoul

PR on Open5e: https://github.com/eepMoody/open5e-api/pull/48

RecursiveStar commented 4 years ago

@daft-develop Your pull request was merged but the values do not seem to be updated, either on the API's end or your end.

958c3624eacbff6aa70b5ec06f78f00b 0990183ed3d484c1029bc2ccce2dcf26

daft-develop commented 4 years ago

@RecursiveStar I created a local build of Open5e with the latest master commit on my machine and the changes have been incorporated and show up as expected on both the local open5e and a local Tetra build pointing to my local open5e.

It looks like the public hosted version of Open5e hasn't been updated to match the latest commits. Both my changes and few others in the Open5e commit history don't show up on the public page. I suspect even though the changes have been pulled in to master, Open5e hasn't updated the public build for whatever reason, possibly queuing up some other changes? You could follow up directly with the open5e project to see if they have a scheduled release or open an issue, perhaps the database just wasn't refreshed.

Tetra-cube commented 4 years ago

Open5e issue