TetragrammatonHermit / naclports

Automatically exported from code.google.com/p/naclports
1 stars 0 forks source link

common_build_scripts/nacl_build.mk has wrong binary names #36

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. build naclports
2. cd into an example
3. type make

What is the expected output? What do you see instead?
it should make. It does not. 
/usr/local/google/nacl_sdk/toolchain/linux_x86/bin/nacl-g++ -Wall 
-Wno-long-long -pthread -DXP_UNIX -Werror -m32 -I/usr/local/google/nacl_sdk -I 
-O2 -c -o client_x86_32.o client.cc
make: /usr/local/google/nacl_sdk/toolchain/linux_x86/bin/nacl-g++: Command not 
found
make: *** [client_x86_32.o] Error 127

What version of the product are you using? On what operating system?
a recent download, I don't see version info anywhere. The nacl_sdk is pepper 16.

Please provide any additional information below.

These are wrong: 
CC = $(NACL_SDK_ROOT)/$(NACL_TOOLCHAIN_DIR)/bin/nacl-gcc
CPP = $(NACL_SDK_ROOT)/$(NACL_TOOLCHAIN_DIR)/bin/nacl-g++
NACL_STRIP = $(NACL_SDK_ROOT)/$(NACL_TOOLCHAIN_DIR)/bin/nacl-strip

The lack the archicture prefix, e.g. nacl-gcc should be i686-nacl-gcc

Original issue reported on code.google.com by rminn...@gmail.com on 17 Feb 2012 at 4:48

GoogleCodeExporter commented 9 years ago
oh, it's easier than that. there is a bin directory with g++, gcc, etc. for 
nacl. nacl_build.mk needs to reference these, not nacl-*

Original comment by rminn...@gmail.com on 18 Feb 2012 at 2:07

GoogleCodeExporter commented 9 years ago
common_build_scripts/nacl_build.mk is not used for any currently building 
examples anymore.  naclports needs some TLC to remove cruft and fix a lot of 
examples that don't build.

See build_tools/common.sh for an example of setting up toolchain variables 
which is used for all the libraries.

Original comment by elijahtaylor@google.com on 1 Mar 2012 at 7:27