Tetrakern / fictioneer

A web fiction theme for WordPress.
https://fictioneer-theme.com
GNU General Public License v3.0
104 stars 16 forks source link

Add View count on stories #12

Closed Nabeelshar closed 9 months ago

Nabeelshar commented 9 months ago

Thanks for comprehensive review, Oh yeah there are a lot of errors to fix i'm still new to contribution, so I get your point(I think??) about the Technical issues, i need to reread it few times.

So what about making views count based on IP ?

Tetrakern commented 9 months ago

So what about making views count based on IP ?

Its a question of how you want to remember a viewer and there are some pitfalls. You can use a session, of course, or store it in a new database table, or temporarily in a Transient (not recommended with large user bases). Then it becomes data science. Anyway, the crux is privacy. Tracking IPs for this purpose requires consent in many countries, so you would also have to deal with anonymization. And IPs are not foolproof either.

You can surely find this topic covered somewhere on the Internet, like Stack Overflow. I'm not going to investigate it further since I won't add this feature to the theme, though. The potential privacy issues and performance impact are not worth displaying a number of dubious accuracy without benefit. I have learned that high view counts are no indication of quality, the same as low ones do not necessarily hint at hidden gems. Never forget, the Twilight books are a multi-million franchise. Never trust the audience.