search

Teun / git-flow-vis

81 stars 12 forks source link

Commit links don't take into account base url for Stash #37

Closed amkonarska closed 9 years ago

amkonarska commented 9 years ago

Our Stash instance has following url: www.example.com/stash When we are clicking on commit links in GitFlowChart it is redirecting us to www.example.com/projects/PROJECT/repos/REPO_NAME/commits/da398a9ef4f79e2892ab5854b658a368e5f610b6 instead of www.example.com/stash/projects/PROJECT/repos/REPO_NAME/commits/da398a9ef4f79e2892ab5854b658a368e5f610b6

Teun commented 9 years ago

Thanks for submitting. I will look into this.

2015-02-25 15:08 GMT+01:00 arzemyk notifications@github.com:

Our Stash instance has following url: www.example.com/stash When we are clicking on commit links in GitFlowChart it is redirecting us to

www.example.com/projects/PROJECT/repos/REPO_NAME/commits/da398a9ef4f79e2892ab5854b658a368e5f610b6 instead of

www.example.com/stash/projects/PROJECT/repos/REPO_NAME/commits/da398a9ef4f79e2892ab5854b658a368e5f610b6

— Reply to this email directly or view it on GitHub https://github.com/Teun/git-flow-vis/issues/37.

Teun commented 9 years ago

I have pushed a fix to master, but I currently cannot test with Stash myself. Can you see if it works? You'd have to select the setting for using the latest version under settings.

amkonarska commented 9 years ago

Unfortunately, after checking this option GitFlowChart is not showing at all. There is loading that ends and stays that way.

remie commented 9 years ago

@arzemyk : are you using a proxy server in your environment? There is a known issue in the Stash add-on with retrieving the development version from github if you are using custom internet connection options.

amkonarska commented 9 years ago

@remie it can be this way, but I am waiting for our admins to confirm. Is there any workaround for this? @Teun is there a possibility to get this as Stash add-on that I can upload to my Stash instance?

Teun commented 9 years ago

Sorry this took so long. I finally found the time to figure out why the 'most current version feature' didn't work. I got the Stash on Docker installation from Atlassian working locally, so I can test much better now. It should work now. @arzemyk can you test? Using the 'source include' option enabled.

amkonarska commented 9 years ago

@Teun 'most current version feature' is working now and bug I reported is not there anymore. Thanks a lot!

amkonarska commented 9 years ago

@Teun can you tell me when it will be officially released?

Teun commented 9 years ago

I'm not sure. The process for getting a new version of the plugin out involves testing against multiple older versions of Stash. This is significant work. But as I'm now working on a few other small improvements, we will probably get a new version out the door in a month or so.