search

TexTools / FFXIV_TexTools_UI

GNU General Public License v3.0
376 stars 62 forks source link

[Bug]: Incomplete PMP import when model is referenced in default_mod.json #315

Open isaki opened 3 weeks ago

isaki commented 3 weeks ago

Expected behavior?

When importing a modpack created in Penumbra with the revision portion of the version missing, all files and mods should be imported.

Actual behavior?

When importing a modpack created in Penumbra with the revision portion of the version missing, some files are not imported. It appears to be possibly be the first one, however, the pack I am using to demonstrate this is very simple. It may actually be skipping the entire first option.

Steps to reproduce the problem

  1. Download this mod: https://www.xivmodarchive.com/modid/103294
  2. Open a transaction and import. No need to change any settings for this bug.
  3. Observe that only the metadata and materials are imported. The model (included in the first, default option) is missing.
  4. Cancel the transaction.
  5. Launch the advanced modpack creation GUI.
  6. Load the modpack from above into the creator.
  7. Change the version to contain a revision (such as 1.3.0 instead of 1.3._)
  8. Save this somewhere as a PMP.
  9. Open a new transaction.
  10. Load the modpack created in step 8.
  11. Observe that three files are now present; the metadata, a material, and a model.

Error messages?

None.

What aspect of FFXIV TexTools were you using, and what Item were you interacting with?

Component: Importer

Has this has been confirmed as an actual bug?

Squall-Leonhart commented 3 weeks ago

Nothing to do with the version string, the original pmp is missing files relevant to connecting the selection to the wizard choices.

Judging by other pmp files, this one has been made incorrectly and the advanced modpackcreator is correcting the mistake.

isaki commented 3 weeks ago

Interestingly, the incorrect pack does with in Penumbra without any modification, if that helps at all.