search

TexTools / xivModdingFramework

GNU General Public License v3.0
9 stars 16 forks source link

[BUG] Error when directory is divided by `\` #41

Closed Bluefissure closed 2 years ago

Bluefissure commented 2 years ago

Should use Path.GetDirectoryName instead of substring in https://github.com/TexTools/xivModdingFramework/blob/1235f17/xivModdingFramework/SqPack/DataContainers/IndexFile.cs#L525

Doc: https://docs.microsoft.com/en-us/dotnet/api/system.io.path.getdirectoryname?view=netframework-4.7

KoraLyn commented 2 years ago

Should be fixed with https://github.com/TexTools/xivModdingFramework/commit/ddeb2acf263b788551322bbd977d52856081a27d

KoraLyn commented 2 years ago

Out of curiosity, what made you run into an issue with this? All internal paths use / as separator afaik.

Bluefissure commented 2 years ago

Out of curiosity, what made you run into an issue with this? All internal paths use / as separator afaik.

From other modding tools such as Penumbra and XivAlex