TexTools / xivModdingFramework

GNU General Public License v3.0
9 stars 16 forks source link

Un-deoptimization library edition #62

Closed helpful-fox-senko-san closed 4 months ago

helpful-fox-senko-san commented 4 months ago

Together with https://github.com/TexTools/FFXIV_TexTools_UI/pull/286

This reduces time on startup loading the item cache on EW database from 3s -> 1s

Model preview loading times are reduced around 3-5x.

Texture loading times are much faster too.

helpful-fox-senko-san commented 4 months ago

This will close #59

Lunaretic commented 4 months ago

Looks good.

Squall-Leonhart commented 4 months ago

This will break the viewer, the Helix Toolkit update requires reimplementing Culling

Squall-Leonhart commented 4 months ago

nvm, forgot the depth peeling wasn't in the framework

helpful-fox-senko-san commented 4 months ago

This will break the viewer, the Helix Toolkit update requires reimplementing Culling

Backface culling toggle does work but this just reminded me that translucency is not working 🧀 I will try to remember where I need to re-add a line to fix that..........

(Edit: Oh you meant the other stuff but yeah I gotta fix translucency mode anyway)

helpful-fox-senko-san commented 4 months ago

Can confirm updating Helix Toolkit broke the Translucency toggle, so its possible it did break other translucency as well (I don't know any examples to check). I'm gonna look in to it and otherwise I guess recommend reverting the update.

helpful-fox-senko-san commented 4 months ago
--- a/FFXIV_TexTools/Views/Models/FullModelView.xaml
+++ b/FFXIV_TexTools/Views/Models/FullModelView.xaml
@@ -49 +49 @@
-                OITRenderMode="DepthPeeling" OITWeightMode="Linear0" ZoomDistanceLimitNear="0.0001">
+                OITRenderMode="SinglePassWeighted" ZoomDistanceLimitNear="0.0001">
diff --git a/FFXIV_TexTools/Views/Models/ModelView.xaml b/FFXIV_TexTools/Views/Models/ModelView.xaml
index d4392d9..eb22afe 100644
--- a/FFXIV_TexTools/Views/Models/ModelView.xaml
+++ b/FFXIV_TexTools/Views/Models/ModelView.xaml
@@ -54 +54 @@
-                OITRenderMode="DepthPeeling" OITWeightMode="Linear0" ZoomDistanceLimitNear="0.0001">
+                OITRenderMode="SinglePassWeighted" ZoomDistanceLimitNear="0.0001">

This appears to have been the correct mode to use :sob: