TexasDigitalLibrary / Vireo

Vireo is a turnkey Electronic Thesis and Dissertation (ETD) Management System.
https://texasdigitallibrary.atlassian.net/wiki/spaces/VUG/pages/87490642/About
GNU General Public License v2.0
44 stars 33 forks source link

DSpace Simple Export with Incomplete Submissions generates invalid zip #1316

Open kaladay opened 5 years ago

kaladay commented 5 years ago

Attempts to export incomplete submissions results in the generation of an invalid zip. The (invalid) zip file downloads successfully, thereby informing the user that the export was a success when the export actually failed.

smutniak commented 5 years ago

This happens if the CLI 'generate' command is used to generate a submission. It appears that the cli generate does not fill out the submission according to its current requirements (required degree name and/or other fields that the form or export needs. (If export needs the field than the issue is to make that field mandatory. In short - we need to bring the submissions generated by cli up to date. We may also need to make certain fields mandatory for a submission. Since some fields may not be required by all exports we should provide an error message instead of producing and erroneous download.

kaladay commented 5 years ago

I used the UI's "Download Export" on the "List ETDs" admin page to generate the DSpace Simple Export. I do not know if the UI calls the CLI for the "Dowload Export" link there. I have not tested CLI.

smutniak commented 5 years ago

How were the submissions in the list generated?

kaladay commented 5 years ago

Manually.

smutniak commented 5 years ago

Fixing issue #1176 should precede work on this so we see what fields are required by dspace but not mandatory in the form.

kaladay commented 1 year ago

This still happens. The invalid zip is actually an HTTP error response containing:

{
  "meta" : {
    "status" : "ERROR",
    "action" : null,
    "message" : "Something went wrong with the export!",
    "id" : null
  },
  "payload" : { }
}
cstarcher commented 4 months ago

This is a problem only with submissions that do not have values for required fields as stated in the original post.

This has not been resolved as of version 4.2.6.

Screenshot 2024-02-29 at 8 37 32 PM