TexasDigitalLibrary / Vireo

Vireo is a turnkey Electronic Thesis and Dissertation (ETD) Management System.
https://texasdigitallibrary.atlassian.net/wiki/spaces/VUG/pages/87490642/About
GNU General Public License v2.0
44 stars 33 forks source link

Custom drop down menus #1675

Open cstarcher opened 1 year ago

cstarcher commented 1 year ago

Relevant Components:

Description Whenever possible, use native HTML5 elements with the semantics required. For instance, {{<select>}} with children {{<option>}} have the necessary semantics to fix the issues with keyboard functionality on most of the offending components, without dealing with attributes or customization.

Using semantically accurate components is important in two ways.

Solution Use semantically accurate elements.

jcreel commented 1 year ago

We are using ul with appropriate role attributes for our dropdown selection. Will this be adequate for screen readers, etc?

ghost commented 1 year ago

@cstarcher you mind if I assign myself this issue?

cstarcher commented 1 year ago

@wwelling It's all yours!

ghost commented 1 year ago

@cstarcher What is the definition of done on this issue?

cstarcher commented 1 year ago

@wwelling That's a good question. It seems this would be a front end code review and refactor. I did not prioritize this one well for the current sprint. I believe there are other specific accessibility issues that are higher priority. I'm going to reprioritize in favor of some others issues. We can revisit it later if there is time.