search

TexasDigitalLibrary / Vireo

Vireo is a turnkey Electronic Thesis and Dissertation (ETD) Management System.
https://texasdigitallibrary.atlassian.net/wiki/spaces/VUG/pages/87490642/About
GNU General Public License v2.0
46 stars 35 forks source link

Deposit Location Test Connection is testing using saved data rather than current settings. #1817

Closed kaladay closed 10 months ago

kaladay commented 1 year ago
  1. Save the Deposit Location.
  2. Edit the Deposit Location, such as changing the URL for the Repository Location.
  3. Make a change to the Deposit Location without saving.
  4. Attempt the Test connection & find available collections.
  5. Observe problem via the network.

At step 5, the URL being used ends up being the saved URL rather than the one currently visible. The whole idea behind testing is to test before saving.

The solution should be to use the currently visible data for the test connection button.

Returning an HTTP 409 is not necessarily correct as well. The fix should likely include better HTTP status code handling.