TexasDigitalLibrary / Vireo

Vireo is a turnkey Electronic Thesis and Dissertation (ETD) Management System.
https://texasdigitallibrary.atlassian.net/wiki/spaces/VUG/pages/87490642/About
GNU General Public License v2.0
44 stars 33 forks source link

[Issue 1883,1879,1878,1877,1876,1766,1682] 1878 continued - System data loader refactor, cleanup, and additional patches #1887

Closed wwelling closed 5 months ago

wwelling commented 6 months ago

Resolves #1883 Resolves #1879 Resolves #1878 Resolves #1877 Resolves #1876 Resolves #1766 Resolves #1682

cstarcher commented 5 months ago

I have reviewed the PR with the following results:

1883 - Resolved

1879 - Resolved

1877 - Resolved

1682 - Resolved

1878 - I would like @smutniak to review this to confirm resolution.

1876 - This fully resolves the issue as described. However, when deleting a field that is already being used as a Customize Column in List view, an error message is generated and the field is deleted from the Workflow Step field list but not from the Customize Columns. This creates a field value that exists but cannot be removed from the Customize Columns. The solution would be to validate that the field has not been assigned to the List view before deletion.

1766 - This addresses the ability to tab into the triptych. However, when there are multiple workflows listed in the triptych, subsequent tabs moves to the last workflow before moving to the Start Submission button preventing the user from selecting any workflows except the last one.

cstarcher commented 5 months ago

I am receiving this error when I select the Default columns button in List view and in the Customize Results Table modal.

2024-01-18 13:45:37.930 ERROR 64188 --- [nio-9000-exec-3] o.t.v.c.SubmissionListController : null java.lang.UnsupportedOperationException: null at java.base/java.util.Collections$UnmodifiableCollection.clear(Collections.java:1079) ~[na:na]