TexasInstruments / processor-sdk-doc

Processor SDK (PSDK) documentation source
https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/latest/exports/docs/devices/AM62X/index.html
Creative Commons Attribution Share Alike 4.0 International
6 stars 19 forks source link

linux: Foundational_Components_IPC_J7*: Fix link to Top Level Makefile #4

Closed aniket-l closed 3 weeks ago

aniket-l commented 1 month ago

Signed-off-by: Aniket Limaye a-limaye@ti.com

nmenon commented 3 weeks ago

rebase on master to get the checkers to run

aniket-l commented 3 weeks ago

rebase on master to get the checkers to run

@nmenon @StaticRocket Not sure what I am missing here... I seem to have added necessary formatting to the commits

Type commit_signoff check failed => 04a924b2eb59a5baf41d57c4484dc3c4ef52756c 
It doesn't match regex: Signed-off-by:.*[A-Za-z0-9]\s+<[\w\.]+@([\w-]+\.)+[\w-]{2,4}>

Looks to me like below change is needed in the regex matching pattern, to match with the '-' character in email-id? <[\w\.]+@([\w-]+\.)+[\w-]{2,4}> => <[\w\.\-]+@([\w-]+\.)+[\w-]{2,4}>

StaticRocket commented 3 weeks ago

Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex.

https://github.com/commit-check/commit-check/pull/184

shenxianpeng commented 3 weeks ago

Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex.

commit-check/commit-check#184

This issue has been resolved.

However, there’s another failure in this run that requires additional permissions in commit-check.yml for pr-comments

permissions:
  contents: write
  pull-requests: write
  repository-projects: write
StaticRocket commented 3 weeks ago

@shenxianpeng yeah, that one's on me. I figured that would be required. I'll update the workflow here and your example workflow since it sets the comment flag to true as well.

StaticRocket commented 3 weeks ago

@cshilwant @praneethbajjuri we need another maintainer to sign off on this.