Closed aniket-l closed 3 weeks ago
rebase on master to get the checkers to run
rebase on master to get the checkers to run
@nmenon @StaticRocket Not sure what I am missing here... I seem to have added necessary formatting to the commits
Type commit_signoff check failed => 04a924b2eb59a5baf41d57c4484dc3c4ef52756c
It doesn't match regex: Signed-off-by:.*[A-Za-z0-9]\s+<[\w\.]+@([\w-]+\.)+[\w-]{2,4}>
Looks to me like below change is needed in the regex matching pattern, to match with the '-' character in email-id?
<[\w\.]+@([\w-]+\.)+[\w-]{2,4}>
=> <[\w\.\-]+@([\w-]+\.)+[\w-]{2,4}>
Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex.
Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex.
This issue has been resolved.
However, there’s another failure in this run that requires additional permissions in commit-check.yml for pr-comments
permissions:
contents: write
pull-requests: write
repository-projects: write
@shenxianpeng yeah, that one's on me. I figured that would be required. I'll update the workflow here and your example workflow since it sets the comment flag to true as well.
@cshilwant @praneethbajjuri we need another maintainer to sign off on this.
Signed-off-by: Aniket Limaye a-limaye@ti.com